Skip to content

Commit

Permalink
SqlServerDsc: Fix keywords to lower-case to align with guideline (#1425)
Browse files Browse the repository at this point in the history
- Changes to SqlServerDsc
  - Fix keywords to lower-case to align with guideline.
  • Loading branch information
johlju authored Sep 9, 2019
1 parent 2337c7c commit 7a70c03
Show file tree
Hide file tree
Showing 9 changed files with 18 additions and 15 deletions.
3 changes: 3 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,9 @@

## Unreleased

- Changes to SqlServerDsc
- Fix keywords to lower-case to align with guideline.

## 13.1.0.0

- Changes to SqlServerDsc
Expand Down
4 changes: 2 additions & 2 deletions DSCResources/MSFT_SqlAG/MSFT_SqlAG.psm1
Original file line number Diff line number Diff line change
Expand Up @@ -158,7 +158,7 @@ function Get-TargetResource
function Set-TargetResource
{
[CmdletBinding()]
Param
param
(
[Parameter(Mandatory = $true)]
[System.String]
Expand Down Expand Up @@ -560,7 +560,7 @@ function Test-TargetResource
{
[CmdletBinding()]
[OutputType([System.Boolean])]
Param
param
(
[Parameter(Mandatory = $true)]
[System.String]
Expand Down
4 changes: 2 additions & 2 deletions DSCResources/MSFT_SqlAGReplica/MSFT_SqlAGReplica.psm1
Original file line number Diff line number Diff line change
Expand Up @@ -169,7 +169,7 @@ function Get-TargetResource
function Set-TargetResource
{
[CmdletBinding()]
Param
param
(
[Parameter(Mandatory = $true)]
[System.String]
Expand Down Expand Up @@ -552,7 +552,7 @@ function Test-TargetResource
{
[CmdletBinding()]
[OutputType([System.Boolean])]
Param
param
(
[Parameter(Mandatory = $true)]
[System.String]
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ $script:localizedData = Get-LocalizedData -ResourceName 'MSFT_SqlDatabaseDefault
The path to the default directory to be configured.
Not used in Get-TargetResource
#>
Function Get-TargetResource
function Get-TargetResource
{
[CmdletBinding()]
[OutputType([System.Collections.Hashtable])]
Expand Down Expand Up @@ -110,7 +110,7 @@ Function Get-TargetResource
Specifies that the resource will only determine if a change is needed if the target node is the active host of the SQL Server Instance.
Not used in Set-TargetResource.
#>
Function Set-TargetResource
function Set-TargetResource
{
[CmdletBinding()]
param
Expand Down
2 changes: 1 addition & 1 deletion Tests/TestHelpers/CommonTestHelper.psm1
Original file line number Diff line number Diff line change
Expand Up @@ -178,7 +178,7 @@ function Remove-IntegrationLoopbackAdapter
#>
function Get-NetIPAddressNetwork
{
Param
param
(
[Parameter(Mandatory = $true)]
[IPAddress]
Expand Down
8 changes: 4 additions & 4 deletions Tests/Unit/MSFT_SqlAGReplica.Tests.ps1
Original file line number Diff line number Diff line change
Expand Up @@ -187,7 +187,7 @@ try
#region Function mocks

$mockConnectSqlServer1 = {
Param
param
(
[Parameter()]
[System.String]
Expand Down Expand Up @@ -290,7 +290,7 @@ try
}

$mockConnectSqlServer2 = {
Param
param
(
[Parameter()]
[System.String]
Expand Down Expand Up @@ -410,7 +410,7 @@ try
}

$mockConnectSqlServer3 = {
Param
param
(
[Parameter()]
[System.String]
Expand Down Expand Up @@ -533,7 +533,7 @@ try
$mockAvailabilityGroupReplicaPropertyValue = '' # Set dynamically during runtime

$mockUpdateAvailabilityGroupReplica = {
Param
param
(
[Parameter()]
[Microsoft.SqlServer.Management.Smo.AvailabilityReplica]
Expand Down
2 changes: 1 addition & 1 deletion Tests/Unit/MSFT_SqlScriptQuery.Tests.ps1
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@

# Suppression of this PSSA rule allowed in tests.
[Diagnostics.CodeAnalysis.SuppressMessageAttribute('PSAvoidUsingConvertToSecureStringWithPlainText', '')]
Param()
param ()

Import-Module -Name (Join-Path -Path $PSScriptRoot -ChildPath '..\TestHelpers\CommonTestHelper.psm1')

Expand Down
4 changes: 2 additions & 2 deletions Tests/Unit/SqlServerDsc.Common.Tests.ps1
Original file line number Diff line number Diff line change
Expand Up @@ -2128,7 +2128,7 @@ InModuleScope 'SqlServerDsc.Common' {
}

$mockConnectSql = {
Param
param
(
[Parameter()]
[System.String]
Expand Down Expand Up @@ -2195,7 +2195,7 @@ InModuleScope 'SqlServerDsc.Common' {
BeforeEach {
$mockSqlVersion = 13
$mockConnectSql = {
Param
param
(
[Parameter()]
[System.String]
Expand Down
2 changes: 1 addition & 1 deletion Tests/Unit/Stubs/Write-ModuleStubFile.ps1
Original file line number Diff line number Diff line change
Expand Up @@ -126,7 +126,7 @@ function Write-ModuleStubFile
$endOfParameter = $true
}

# Format Param line
# Format param line
'param\($'
{
$line = $line -replace 'param\(','param'
Expand Down

0 comments on commit 7a70c03

Please sign in to comment.