Fix #19 - Fix #18

dshikashio · Jun 27, 2024 · 9f9b19b · 9f9b19b
1 parent 99fe5bd
commit 9f9b19b
Show file tree

Hide file tree

Showing 5 changed files with 18 additions and 8 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,3 +1,4 @@
 ## Current Changes
-* 2.2.10
-  * Better search for Windbg DLLs using registry and allowing user override
+* 2.2.11
+  * Fix #18 - Fix SetImplicitProcessDataOffset
+  * Fix #19 - Implement CreateProcess2
diff --git a/README.md b/README.md
@@ -55,6 +55,9 @@ k.attach("net:port=50000,key=1.2.3.4")
 
 
 ## Release History
+* 2.2.11
+  * Fix #18 - Fix SetImplicitProcessDataOffset
+  * Fix #19 - Implement CreateProcess2
 * 2.2.10
   * Better search for Windbg DLLs using registry and allowing user override
 * 2.2.9

diff --git a/pybag/dbgeng/idebugclient.py b/pybag/dbgeng/idebugclient.py
@@ -451,10 +451,16 @@ def SetEventCallbacksWide(self, *args):
         raise exception.E_NOTIMPL_Error
 
     def CreateProcess2(self, cmdline, options, initial_dir, env):
-        raise exception.E_NOTIMPL_Error
-        #self._proc_server_hndl
-        #hr = self._cli.CreateProcess2()
-        #exception.check_err(hr)
+        if isinstance(cmdline, str):
+            cmdline = cmdline.encode()
+        if isinstance(initial_dir, str):
+            initial_dir = initial_dir.encode()
+        if isinstance(env, str):
+            env = env.encode()
+        # env is \0 delineated key=value pairs
+        # options is instance of DbgEng._DEBUG_CREATE_PROCESS_OPTIONS()
+        hr = self._cli.CreateProcess2(self._proc_server_hndl, cmdline, byref(options), sizeof(options), initial_dir, env)
+        exception.check_err(hr)
 
     def CreateProcess2Wide(self, *args):
         raise exception.E_NOTIMPL_Error

diff --git a/pybag/dbgeng/idebugsystemobjects.py b/pybag/dbgeng/idebugsystemobjects.py
@@ -186,7 +186,7 @@ def GetImplicitProcessDataOffset(self):
         exception.check_err(hr)
         return offset.value
 
-    def SetImplicitProcessDataOffset(self):
+    def SetImplicitProcessDataOffset(self, offset):
         hr = self._sys.SetImplicitProcessDataOffset(offset)
         exception.check_err(hr)
 

diff --git a/setup.py b/setup.py
@@ -6,7 +6,7 @@
 README = (HERE / "README.md").read_text()
 
 setup(name='Pybag',
-      version='2.2.10',
+      version='2.2.11',
       description='Python wrappers for DbgEng from Windbg',
       long_description=README,
       long_description_content_type="text/markdown",