fix: history object reference

dsrkafuu · Mar 18, 2022 · 325fa0b · 325fa0b
1 parent 4de1694
commit 325fa0b
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 5 deletions.
diff --git a/src/store/modules/API.ts b/src/store/modules/API.ts
@@ -65,10 +65,16 @@ class API {
   /** @mobx actions */
 
   /**
-   * show a history data
+   * show a history data (-1 to disable)
    */
-  showHistory(data: HistoryData | null) {
-    this.history = data;
+  showHistory(index: number) {
+    if (index < 0 || index >= 5 || !this.historys[index]) {
+      this.history = null;
+      return;
+    }
+    // direct set reference instead of deep clone,
+    // for Object.is() comparsion
+    this.history = this.historys[index];
   }
   /**
    * update new combat data

diff --git a/src/views/SettingsHistory.tsx b/src/views/SettingsHistory.tsx
@@ -69,7 +69,7 @@ function SettingsHistory() {
         current={!api.history}
         duration={api.data.encounter.duration}
         zone={api.data.encounter.zoneName}
-        onClick={() => api.showHistory(null)}
+        onClick={() => api.showHistory(-1)}
       />
       {api.historys.map((item, idx) => {
         return (
@@ -79,7 +79,7 @@ function SettingsHistory() {
             time={item.time}
             duration={item.encounter.duration}
             zone={item.encounter.zoneName}
-            onClick={() => api.showHistory(item)}
+            onClick={() => api.showHistory(idx)}
           />
         );
       })}