Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix version badge on README.md -> v1.0.0-RC.1 #477

Merged
merged 1 commit into from
Jun 22, 2023

Conversation

xellos00
Copy link
Member

@xellos00 xellos00 commented Jun 22, 2023

1. Type of change

Please delete options that are not relevant.

  • New feature
  • Enhancement
  • Bug/fix (non-breaking change which fixes an issue)
  • others (anything other than above)

2. Summary

Please include a summary of the changes and which issue is fixed or solved.

Related: #475

Summary

Version & License badge should be

v1.0.0 & GPL-3.0


3. Comments

Please, leave a comments if there's further action that requires.

 dongyookang DK 🐸   ~/ffplay/GolandProjects/xellos/vatz   ISSUE-475
 make coverage
fatal: No names found, cannot describe anything.
?       github.com/dsrvlabs/vatz        [no test files]
?       github.com/dsrvlabs/vatz/manager/types  [no test files]
?       github.com/dsrvlabs/vatz/mocks  [no test files]
ok      github.com/dsrvlabs/vatz/cmd    3.211s  coverage: 23.5% of statements
ok      github.com/dsrvlabs/vatz/manager/api    0.572s  coverage: 0.0% of statements [no tests to run]
ok      github.com/dsrvlabs/vatz/manager/config 0.456s  coverage: 77.8% of statements
ok      github.com/dsrvlabs/vatz/manager/dispatcher     0.836s  coverage: 7.1% of statements
ok      github.com/dsrvlabs/vatz/manager/executor       0.966s  coverage: 68.9% of statements
ok      github.com/dsrvlabs/vatz/manager/healthcheck    1.243s  coverage: 46.5% of statements
ok      github.com/dsrvlabs/vatz/manager/plugin 7.699s  coverage: 50.6% of statements
ok      github.com/dsrvlabs/vatz/monitoring/prometheus  1.094s  coverage: 0.0% of statements
ok      github.com/dsrvlabs/vatz/rpc    2.526s  coverage: 67.2% of statements
ok      github.com/dsrvlabs/vatz/utils  0.697s  coverage: 7.1% of statements
 dongyookang DK 🐸   ~/ffplay/GolandProjects/xellos/vatz   ISSUE-475

@xellos00 xellos00 self-assigned this Jun 22, 2023
@xellos00 xellos00 added Vatz Project Name area:svc Anything related to Vatz Service. type:hotfix Bug fix that must apply to released version labels Jun 22, 2023
Copy link
Member

@meetrick meetrick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@xellos00 xellos00 changed the title Fix version badge on README.md -> RC.2 Fix version badge on README.md -> v1.0.0-RC.1 Jun 22, 2023
Copy link
Member

@gnongs gnongs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@xellos00 xellos00 merged commit edfefaa into dsrvlabs:v1.0.0-rc.1 Jun 22, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:svc Anything related to Vatz Service. type:hotfix Bug fix that must apply to released version Vatz Project Name
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants