-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Dockerfile into Vatz #590
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@xellos00 any plan to apply alpine linux rather than Debian? |
- from Debian to Alpine
- from Debian to Alpine
Thanks for comment this out, I didn't do this in purpose. it's merely copied mistake from my test docker script. I was trying to change it either of arpine:latest or ubuntu:latest. I updated code because you are suggsting arpine for its lightwight. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Additionally, I suggest to fix specific version rather using "latest" one. It could raise unexpected behavior when the image updated.
FYI. Alpine is de facto standard due to security and lightweight of its result.
1. Type of change
Please delete options that are not relevant.
2. Summary
Related: # (issue)
Add Dockerfile into Vatz, for the running a watcher, we need to dockerlize vatz, and then run it on k8s
and therefore this dockerlize vatz
You can test it via command
Summary
close #338
3. Comments