Update API to support delivery confirmation API #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
programWhiz
commented
Apr 16, 2017
| }), | ||
| var xml = templates[req](data); | ||
| // Remove whitespace between XML elements | ||
| xml = xml.replace(/>\s*</mg, '><'); |
There was a problem hiding this comment.
At least in my testing, this was required to get it to work right.
programWhiz
commented
Apr 16, 2017
| request({ | ||
| url: url, | ||
| method: 'GET', | ||
| qs: { API: api, XML: xml } |
There was a problem hiding this comment.
Also wouldn't work without URI encoding all the stuff, so it seemed cleaner to use the builtin request functionality rather than a template.
|
Thanks @programWhiz, could you add some tests for it? Sorry for not getting back to you sooner, I don't remember ever getting a notification for it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.