Fix packages using Get-ItemProperty to retrieve uninstall keys

[dtgm]

Pre-fix

$packageName = '{{PackageName}}'
$packageSearch = "$packageName"
$installerType = 'exe'
$silentArgs = '/VERYSILENT /SUPPRESSMSGBOXES /NORESTART /SP-'
$validExitCodes = @(0)
try {
  Get-ItemProperty -Path @( 'HKLM:\Software\Wow6432Node\Microsoft\Windows\CurrentVersion\Uninstall\*',
                            'HKLM:\Software\Microsoft\Windows\CurrentVersion\Uninstall\*',
                            'HKCU:\Software\Microsoft\Windows\CurrentVersion\Uninstall\*' ) `
                   -ErrorAction:SilentlyContinue `
  | Where-Object   { $_.DisplayName -like "$packageSearch*" } `
  | ForEach-Object { Uninstall-ChocolateyPackage -PackageName "$packageName" `
                                                 -FileType "$installerType" `
                                                 -SilentArgs "$($silentArgs)" `
                                                 -File "$($_.UninstallString)" `
                                                 -ValidExitCodes $validExitCodes }
} catch {
  throw $_.Exception
}

ToDo

• Add dependency to nuspec

no longer necessary as it was added as a native helper in 0.9.10-beta (chocolatey/choco@91db949)
Still necessary for backward compatibility until community packages require supporting >=0.9.10 (likely not until 2017)

<dependencies> 
  <dependency id="chocolatey-uninstall.extension" /> 
</dependencies>

• Replace relevant lines in chocolateyUninstall.ps1
• $packageSearch to $softwareName

Get-ItemProperty -Path @( 'HKLM:\Software\Wow6432Node\Microsoft\Windows\CurrentVersion\Uninstall\*',
                   'HKLM:\Software\Microsoft\Windows\CurrentVersion\Uninstall\*',
                   'HKCU:\Software\Microsoft\Windows\CurrentVersion\Uninstall\*' ) `
                 -ErrorAction:SilentlyContinue `
| Where-Object   { $_.DisplayName -like "$packageSearch*" } `

to

[array]$key = Get-UninstallRegistryKey -SoftwareName $softwareName

| ForEach-Object { Uninstall-ChocolateyPackage -PackageName "$packageName" `
                                    -FileType "$installerType" `
                                    -SilentArgs "$($silentArgs)" `
                                    -File "$($_.UninstallString)" `
                                    -ValidExitCodes $validExitCodes }

to

$key | ForEach-Object {
       Uninstall-ChocolateyPackage -PackageName "$packageName" `
                                   -FileType "$installerType" `
                                   -SilentArgs "$($silentArgs)" `
                                   -File "$($_.UninstallString)" `
                                   -ValidExitCodes $validExitCodes}

ToDo (future)

Switch to parameters to hash

$packageName = '{{PackageName}}'
$softwareName= "$packageName"
$installerType = 'exe'
$silentArgs = '/VERYSILENT /SUPPRESSMSGBOXES /NORESTART /SP-'
$validExitCodes = @(0)