[fix] 修复使用子事务屏障即使失败还返回成功的问题

dtm-php · Jul 11, 2023 · caeca3a · caeca3a
2 parents e1a4284 + 93b6eca
commit caeca3a
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 2 deletions.
diff --git a/src/Middleware/DtmMiddleware.php b/src/Middleware/DtmMiddleware.php
@@ -72,7 +72,7 @@ public function process(ServerRequestInterface $request, RequestHandlerInterface
             $barrier = $this->config->get('dtm.barrier.apply', []);
 
             $businessCall = function () use ($handler, $request) {
-                $handler->handle($request);
+                return $handler->handle($request);
             };
 
             if (in_array($class . '::' . $method, $barrier)) {

diff --git a/src/MySqlBarrier.php b/src/MySqlBarrier.php
@@ -10,6 +10,7 @@
 
 use DtmClient\Constants\Branch;
 use DtmClient\Constants\Operation;
+use DtmClient\Constants\Result;
 use DtmClient\Constants\TransType;
 use DtmClient\DbTransaction\DBTransactionInterface;
 use DtmClient\Exception\DuplicatedException;
@@ -59,7 +60,10 @@ public function call(callable $businessCall): bool
                 return true;
             }
 
-            $businessCall();
+            $response = $businessCall();
+            if ($response->getStatusCode() !== Result::SUCCESS_STATUS) {
+                throw new FailureException();
+            }
 
             $this->DBTransaction->commit();