Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor QStash signature verification to use raw request body #1883

Merged
merged 4 commits into from
Jan 13, 2025

Conversation

devkiran
Copy link
Collaborator

@devkiran devkiran commented Jan 13, 2025

  • Updated multiple API routes to read the raw body from requests instead of parsing JSON directly.
  • Modified the verifyQstashSignature function to accept the raw body for signature verification.
  • Ensured consistent handling of request bodies across various endpoints, improving reliability in signature validation.

- Updated multiple API routes to read the raw body from requests instead of parsing JSON directly.
- Modified the `verifyQstashSignature` function to accept the raw body for signature verification.
- Ensured consistent handling of request bodies across various endpoints, improving reliability in signature validation.
Copy link

vercel bot commented Jan 13, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
dub ✅ Ready (Inspect) Visit Preview Jan 13, 2025 3:45pm

@devkiran devkiran marked this pull request as ready for review January 13, 2025 11:09
@devkiran devkiran requested a review from steven-tey January 13, 2025 11:09
@steven-tey steven-tey enabled auto-merge January 13, 2025 15:41
@steven-tey steven-tey added this pull request to the merge queue Jan 13, 2025
Merged via the queue into main with commit 0c94cb0 Jan 13, 2025
6 checks passed
@steven-tey steven-tey deleted the qstash-signature-rework branch January 13, 2025 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants