Skip to content

Commit

Permalink
fix: Compatibility with clang19 2
Browse files Browse the repository at this point in the history
  • Loading branch information
krlmlr committed Jun 5, 2024
1 parent 8b2a073 commit 977dbc8
Show file tree
Hide file tree
Showing 2 changed files with 26 additions and 1 deletion.
25 changes: 25 additions & 0 deletions patch/0012-fix-Compatibility-with-clang19-2.patch
Original file line number Diff line number Diff line change
@@ -0,0 +1,25 @@
From 621fad86f53959a7984c3bd795bace9e1737981b Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Kirill=20M=C3=BCller?= <kirill@cynkra.com>
Date: Wed, 5 Jun 2024 16:29:01 +0200
Subject: [PATCH] fix: Compatibility with clang19 2

---
src/duckdb/src/execution/window_executor.cpp | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/duckdb/src/execution/window_executor.cpp b/src/duckdb/src/execution/window_executor.cpp
index 4d6b9b09..e649ff2e 100644
--- a/src/duckdb/src/execution/window_executor.cpp
+++ b/src/duckdb/src/execution/window_executor.cpp
@@ -193,7 +193,7 @@ private:
template <typename T, typename OP>
struct OperationCompare : public std::function<bool(T, T)> {
inline bool operator()(const T &lhs, const T &val) const {
- return OP::template Operation(lhs, val);
+ return OP::template Operation<T>(lhs, val);
}
};

--
2.43.0

2 changes: 1 addition & 1 deletion src/duckdb/src/execution/window_executor.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -193,7 +193,7 @@ struct WindowColumnIterator {
template <typename T, typename OP>
struct OperationCompare : public std::function<bool(T, T)> {
inline bool operator()(const T &lhs, const T &val) const {
return OP::template Operation(lhs, val);
return OP::template Operation<T>(lhs, val);
}
};

Expand Down

0 comments on commit 977dbc8

Please sign in to comment.