Merge pull request #516 from duckdb/f-tweak

Fix signedness
duckdb · Oct 20, 2024 · f3e79c3 · f3e79c3
2 parents 169cc0a + 9fa02f5
commit f3e79c3
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 7 deletions.
diff --git a/src/reltoaltrep.cpp b/src/reltoaltrep.cpp
@@ -147,12 +147,6 @@ struct AltrepVectorWrapper {
 	void *Dataptr() {
 		if (transformed_vector.data() == R_NilValue) {
 			auto res = rel->GetQueryResult();
-			auto error = res->GetError();
-			if (error != "") {
-				Rprintf("accessing column %" PRIu64 ":\n%s\n", column_index, error.c_str());
-				//rel->res = nullptr;
-				//res = rel->GetQueryResult();
-			}
 
 			transformed_vector = duckdb_r_allocate(res->types[column_index], res->RowCount());
 			idx_t dest_offset = 0;

diff --git a/src/rfuns.cpp b/src/rfuns.cpp
@@ -796,7 +796,7 @@ void InExecute(DataChunk &args, ExpressionState &state, Vector &result) {
 	auto is_in_y = [&](LHS_TYPE left) {
 		// special case when there are no NAs in y
 		if (!na_in_y) {
-			for (int i = 0; i < y_size; i++) {
+			for (idx_t i = 0; i < y_size; i++) {
 				if (try_equal(left, y_data[i])) {
 					return true;
 				}