From 9898a733d68affdae582ea4d0c7d5ffa0d153d74 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Kirill=20M=C3=BCller?= Date: Sun, 20 Oct 2024 15:26:53 +0200 Subject: [PATCH 1/2] Fix signedness --- src/rfuns.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/rfuns.cpp b/src/rfuns.cpp index 0f0ee1f26..f42e15bd8 100644 --- a/src/rfuns.cpp +++ b/src/rfuns.cpp @@ -796,7 +796,7 @@ void InExecute(DataChunk &args, ExpressionState &state, Vector &result) { auto is_in_y = [&](LHS_TYPE left) { // special case when there are no NAs in y if (!na_in_y) { - for (int i = 0; i < y_size; i++) { + for (idx_t i = 0; i < y_size; i++) { if (try_equal(left, y_data[i])) { return true; } From 9fa02f5d47b8c6c371abac15709d61b25cf7320e Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Kirill=20M=C3=BCller?= Date: Sun, 20 Oct 2024 18:08:45 +0200 Subject: [PATCH 2/2] Remove debugging code --- src/reltoaltrep.cpp | 6 ------ 1 file changed, 6 deletions(-) diff --git a/src/reltoaltrep.cpp b/src/reltoaltrep.cpp index a7662bfb1..eff66620d 100644 --- a/src/reltoaltrep.cpp +++ b/src/reltoaltrep.cpp @@ -147,12 +147,6 @@ struct AltrepVectorWrapper { void *Dataptr() { if (transformed_vector.data() == R_NilValue) { auto res = rel->GetQueryResult(); - auto error = res->GetError(); - if (error != "") { - Rprintf("accessing column %" PRIu64 ":\n%s\n", column_index, error.c_str()); - //rel->res = nullptr; - //res = rel->GetQueryResult(); - } transformed_vector = duckdb_r_allocate(res->types[column_index], res->RowCount()); idx_t dest_offset = 0;