-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Download duckdb library from GitHub #513
Conversation
Should we not just get the tarball from |
We could at some point, yes. I wouldn't change it right now, for a variety of reasons. |
There was some discussion about dealing with package sizes in r-polars some time ago. Turns out some packages are able to get exceptions - example. Perhaps you could ask CRAN maintainers for a size exception for DuckDB? Would be a lot more convenient for users if the package could keep the full source in the same style as most CRAN packages. |
Thanks, I'd like to know more about that. It's not that we can't release the package, but the release no longer is automatic. What does the polars exception look like exactly? |
I don't think CRAN allows downloading files from the internet. |
Thanks. I remember the rule about binary files, but what about a source tarball? xz-compressing the sources seems like a neat idea, but it will complicate the release process. |
It is listed as a last option and I am not sure if CRAN will allow downloads from GitHub.
I think we can add the tarball to gitignore and branch the build process by the presence or absence of the tarball and only attach the tarball if we are submitting to CRAN. |
It looks like I could create a Curious if this works on Windows. |
To avoid the 500000 bytes boundary on CRAN.