-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: Add csv reading test for duckdb_read_csv(na.strings = )
#10
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. It's not immediately obvious what this test tests. Would it help writing a literal CSV string to a file, or pointing to a file that is already part of the codebase?
c892158
to
bf309a8
Compare
It just tests to make sure null values are properly read from a csv file using the parameter passed when Potentially some users write to CSV using R and read using duckdb, so it's nice to make sure NA values are respected when the |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #10 +/- ##
=======================================
Coverage 85.89% 85.89%
=======================================
Files 106 106
Lines 3602 3602
=======================================
Hits 3094 3094
Misses 508 508 ☔ View full report in Codecov by Sentry. |
a0c7ed6
to
660fc86
Compare
660fc86
to
de3dd41
Compare
duckdb_read_csv(na.strings = )
Thanks! |
prompted by this issue
duckdb/duckdb#8590