Fix extension bugs (#366)

* Ensure private addresses are refreshed

Signed-off-by: Emanuele Feliziani <feliziani.emanuele@gmail.com>

* Fix button sometimes not clickable

Signed-off-by: Emanuele Feliziani <feliziani.emanuele@gmail.com>

* Fix flytap.com username

Signed-off-by: Emanuele Feliziani <feliziani.emanuele@gmail.com>

* Commit compiled code

Signed-off-by: Emanuele Feliziani <feliziani.emanuele@gmail.com>

* Fix test failure

Signed-off-by: Emanuele Feliziani <feliziani.emanuele@gmail.com>

---------

Signed-off-by: Emanuele Feliziani <feliziani.emanuele@gmail.com>

src/DeviceInterface/InterfacePrototype.js

@@ -379,18 +379,20 @@ class InterfacePrototype {
          * This is desktop only: was  it a private address? if so, save it with
          * the trigger 'emailProtection' so that native sides can use it
          */
-        if (isPrivateAddress && 'emailAddress' in data && data.emailAddress) {
+        if (isPrivateAddress) {
             this.refreshAlias()
-            this.emailProtection.storeReceived(data.emailAddress)
-
-            /** @type {DataStorageObject} */
-            const formValues = {
-                credentials: {
-                    username: data.emailAddress,
-                    autogenerated: true
+            if ('emailAddress' in data && data.emailAddress) {
+                this.emailProtection.storeReceived(data.emailAddress)
+
+                /** @type {DataStorageObject} */
+                const formValues = {
+                    credentials: {
+                        username: data.emailAddress,
+                        autogenerated: true
+                    }
                 }
+                this.storeFormData(formValues, 'emailProtection')
             }
-            this.storeFormData(formValues, 'emailProtection')
         }
 
         await this.removeTooltip()

src/Form/selectors-css.js

@@ -245,6 +245,8 @@ const username = [
     `input[id="username" i]`,
     `input[name="_user" i]`,
     `input[name="login_username" i]`,
+    // https://www.flytap.com/
+    `input[name^="login-user-account" i]`,
     `input[placeholder^="username" i]`
 ]
 

src/Form/test-cases/flytap_login.html

@@ -0,0 +1,43 @@
+<!-- https://www.flytap.com/en-pt/ -->
+<form id="js-login-account-modal" autocomplete="off" novalidate="novalidate">
+    <fieldset>
+        <legend class="prop-hide--sreader">Sign into your account</legend>
+        <div class="matrix-tap__row">
+            <div class="matrix-tap__col">
+                <div class="formdefault-tap__field-group light-input-tap">
+                    <input class="formdefault-tap__input-field vld-email-tpnumber clearinput-tap-field" name="login-user-account-modal" id="login-user-account-modal" type="text" placeholder=" " data-manual-scoring="username"><button class="clearinput-tap-buttton prop-display--none" aria-label="clearinput">clearinput</button>
+                    <div class="formdefault-tap__input-label-wrapper">
+                        <label class="formdefault-tap__input-label" for="login-user-account-modal">Email or Client Number (TP)</label>
+                    </div>
+                </div>
+            </div>
+        </div>
+        <div class="matrix-tap__row">
+            <div class="matrix-tap__col">
+                <div class="formdefault-tap__field-group light-input-tap">
+                    <div class="formdefault-tap__input-password-wrapper">
+                        <input type="password" name="login-pass-account-modal" id="login-pass-account-modal" class="formdefault-tap__input-field" maxlength="32" value="" autocapitalize="off" placeholder=" " required="" aria-required="true" data-manual-scoring="password">
+                        <button type="button" id="for-2-login-pass-account-modal" class="link js-passwordChars">
+                            <span class="icn-svg svg-icn-hide-pass-grey">Hide password</span>
+                            <span class="icn-svg svg-icn-show-pass-grey">Show password</span>
+                        </button>
+                        <div class="formdefault-tap__input-label-wrapper">
+                            <label class="formdefault-tap__input-label" for="login-pass-account-modal">Password</label>
+                        </div>
+                    </div>
+                </div>
+            </div>
+        </div>
+        <div class="matrix-tap__row">
+            <div class="matrix-tap__col">
+                <div class="formdefault-tap__field-group">
+                    <div class="formdefault-tap__input-checker-wrapper formdefault-tap__input-checker-color-variation checked">
+                        <input class="formdefault-tap__input-checker-input" type="checkbox" name="login-save-account-modal" id="login-save-account-modal" value="Remember me" checked="">
+                        <label class="formdefault-tap__input-label--check" for="login-save-account-modal">
+                            Remember me                                            </label>
+                    </div>
+                </div>
+            </div>
+        </div>
+    </fieldset>
+</form>

src/Form/test-cases/index.json

@@ -495,5 +495,7 @@
   { "html": "ua_ctcorpmpc_com-signup.html" },
   { "html": "joybird_com.html" },
   { "html": "ikea_signup-verification.html", "expectedSubmitFalsePositives": 2 },
-  { "html": "chase_2fa-verification-step.html", "expectedFailures": ["unknown"] }
+  { "html": "chase_2fa-verification-step.html", "expectedFailures": ["unknown"] },
+  { "html": "flytap_login.html" }
+
 ]

src/UI/HTMLTooltip.js

@@ -290,7 +290,7 @@ export class HTMLTooltip {
     dispatchClick () {
         const handler = this.clickableButtons.get(this.activeButton)
         if (handler) {
-            if (this.activeButton.matches('.wrapper:not(.top-autofill) *:hover, .currentFocus')) {
+            if (this.activeButton.matches('.wrapper:not(.top-autofill) button:hover, .wrapper:not(.top-autofill) a:hover, .currentFocus')) {
                 safeExecute(this.activeButton, handler, {
                     checkVisibility: this.options.checkVisibility
                 })