Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat: Implement this type in method parameter #1062

Merged
merged 1 commit into from
Aug 10, 2023
Merged

Feat: Implement this type in method parameter #1062

merged 1 commit into from
Aug 10, 2023

Conversation

sunrabbit123
Copy link
Collaborator

Description:

// @strictNullChecks: true
// @declaration: true


class A<T> {
	props: T & { foo: string };
}

class B extends A<{ x: number}> {
	f(p: this["props"]) {
		p.x;
	}
}

BREAKING CHANGE:

Related issue (if exists):

@github-actions
Copy link

github-actions bot commented Aug 9, 2023

Thank you for the PR!
Commit: 0833fd0

Files to check

These are files which is affected by the current PR, but not reflected. If there's no file below this message, please ignore this message.

You can run ./scripts/auto-unignore.sh from crates/stc_ts_file_analyzer for typescript files, and ./scripts/check.sh from crates/stc_ts_type_checker for *.stats.rust-debug files.

kdy1
kdy1 approved these changes Aug 10, 2023
View reviewed changes
Copy link
Member

@kdy1 kdy1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@kdy1 kdy1 merged commit 0130bbe into dudykr:main Aug 10, 2023
6 checks passed
@kdy1 kdy1 added this to the v0.0.1: Correctness milestone Aug 10, 2023
@sunrabbit123 sunrabbit123 deleted the fix/1 branch August 10, 2023 03:33
sunrabbit123 added a commit to sunrabbit123/stc that referenced this pull request Aug 13, 2023
@sunrabbit123
feat: Implement this types in method parameters (dudykr#1062)
bd4d5aa 
**Description:**

```ts
// @strictNullChecks: true
// @declaration: true

class A<T> {
	props: T & { foo: string };
}

class B extends A<{ x: number}> {
	f(p: this["props"]) {
		p.x;
	}
}
```
sunrabbit123 added a commit to sunrabbit123/stc that referenced this pull request Aug 13, 2023
@sunrabbit123
feat: Implement this types in method parameters (dudykr#1062)
8f18393 
**Description:**

```ts
// @strictNullChecks: true
// @declaration: true

class A<T> {
	props: T & { foo: string };
}

class B extends A<{ x: number}> {
	f(p: this["props"]) {
		p.x;
	}
}
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kdy1 kdy1 kdy1 approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
v0.0.1: Correctness
Development

Successfully merging this pull request may close these issues.
2 participants
@sunrabbit123 @kdy1