Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Create Type::get_any_key_type #1066

Merged
merged 3 commits into from
Aug 14, 2023
Merged

Conversation

sunrabbit123
Copy link
Collaborator

Description:
We've isolated duplicate types because it's unpleasant to look at the code if the keyword is stretched every time.

BREAKING CHANGE:

Related issue (if exists):

Copy link
Member

@kdy1 kdy1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

Copy link
Member

@kdy1 kdy1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you rebase?

@github-actions
Copy link

github-actions bot commented Aug 13, 2023

Thank you for the PR!
Commit: 5ad52f1

Files to check

These are files which is affected by the current PR, but not reflected. If there's no file below this message, please ignore this message.

You can run ./scripts/auto-unignore.sh from crates/stc_ts_file_analyzer for typescript files, and ./scripts/check.sh from crates/stc_ts_type_checker for *.stats.rust-debug files.

@sunrabbit123 sunrabbit123 requested a review from kdy1 August 14, 2023 01:14
@kdy1 kdy1 changed the title refactor: extract get key type function refactor: Create Type::get_any_key_type Aug 14, 2023
@kdy1 kdy1 enabled auto-merge (squash) August 14, 2023 09:46
@kdy1 kdy1 merged commit f78187b into dudykr:main Aug 14, 2023
8 checks passed
@sunrabbit123 sunrabbit123 deleted the fix/1 branch August 14, 2023 10:01
sunrabbit123 added a commit to sunrabbit123/stc that referenced this pull request Aug 14, 2023
sunrabbit123 added a commit to sunrabbit123/stc that referenced this pull request Aug 15, 2023
sunrabbit123 added a commit to sunrabbit123/stc that referenced this pull request Aug 18, 2023
sunrabbit123 added a commit to sunrabbit123/stc that referenced this pull request Aug 18, 2023
sunrabbit123 added a commit to sunrabbit123/stc that referenced this pull request Aug 20, 2023
sunrabbit123 added a commit to sunrabbit123/stc that referenced this pull request Aug 20, 2023
sunrabbit123 added a commit to sunrabbit123/stc that referenced this pull request Aug 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants