Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Union the type of an optional property of a mapped type with undefined #1073

Merged
merged 2 commits into from
Aug 24, 2023
Merged

feat: Union the type of an optional property of a mapped type with undefined #1073

merged 2 commits into from
Aug 24, 2023

Conversation

sunrabbit123
Copy link
Collaborator

Description:

function f10<T>(x: T, y: Partial<T>, k: keyof T) {
    x[k] = y[k];  // Error
    y[k] = x[k];
}

BREAKING CHANGE:

Related issue (if exists):

@sunrabbit123 sunrabbit123 mentioned this pull request Aug 20, 2023
Merged
8 tasks
@github-actions
Copy link

Thank you for the PR!
Commit: 29038d7

Files to check

These are files which is affected by the current PR, but not reflected. If there's no file below this message, please ignore this message.

You can run ./scripts/auto-unignore.sh from crates/stc_ts_file_analyzer for typescript files, and ./scripts/check.sh from crates/stc_ts_type_checker for *.stats.rust-debug files.

@sunrabbit123 sunrabbit123 added this to the v0.0.1: Correctness milestone Aug 23, 2023
kdy1
kdy1 approved these changes Aug 24, 2023
View reviewed changes
Copy link
Member

@kdy1 kdy1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@kdy1 kdy1 changed the title feat: optional mapped type property type should be undefined | propertyType feat: Union optional property of a mapped type with undefined Aug 24, 2023
@kdy1 kdy1 changed the title feat: Union optional property of a mapped type with undefined feat: Union the type of an optional property of a mapped type with undefined Aug 24, 2023
@kdy1 kdy1 merged commit f46b724 into dudykr:main Aug 24, 2023
8 checks passed
sunrabbit123 added a commit to sunrabbit123/stc that referenced this pull request Aug 30, 2023
@sunrabbit123
feat: Union the type of an optional property of a mapped type with `u…
fab931a 
…ndefined` (dudykr#1073)

**Description:**

```ts
function f10<T>(x: T, y: Partial<T>, k: keyof T) {
    x[k] = y[k];  // Error
    y[k] = x[k];
}
```
@sunrabbit123 sunrabbit123 deleted the fix/8 branch September 2, 2023 05:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kdy1 kdy1 kdy1 approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
v0.0.1: Correctness
Development

Successfully merging this pull request may close these issues.
2 participants
@sunrabbit123 @kdy1