-
-
Notifications
You must be signed in to change notification settings - Fork 166
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: (PoC) impl wasm support for playground. #1082
Conversation
@kdy1 If this issue passes, I think we should create an stc-playground repository. |
Thank you for the PR! Files to checkThese are files which is affected by the current PR, but not reflected. If there's no file below this message, please ignore this message. You can run
|
@AcrylicShrimp |
|
I resolved all problems. Should I do rebase? @sunrabbit123 |
Resolved with commit(7dc35c8a8a0d64703ab152e). Thank you. May I ask for a review? @kdy1 |
I checked the related issue |
I agree with this. In my experience, we will want many APIs for the playground not exposed to normal wasm bindings |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
**Description:** This PR implements checker behaviors for `wasm` binding. By supporting wasm, implementing playground will become very easy. I also implemented PoC of playground and it works well. I'll contribute on that when this PR is ready and merged. Due to the constraints of wasm, there is a few APIs that should not be used. Below is the list. - `std::time::Instant` - `mimalloc_rust` from `swc_node_base` - All file-system related APIs. We dropped some code to avoid use of the APIs, and this PR contains those changes. I marked this PR as draft; we have to manage them somehow before merge it. **Related issue:** - dudykr#300 - dudykr#1021
Description:
This PR implements checker behaviors for
wasm
binding. By supporting wasm, implementing playground will become very easy. I also implemented PoC of playground and it works well. I'll contribute on that when this PR is ready and merged.Due to the constraints of wasm, there is a few APIs that should not be used. Below is the list.
std::time::Instant
mimalloc_rust
fromswc_node_base
We dropped some code to avoid use of the APIs, and this PR contains those changes. I marked this PR as draft; we have to manage them somehow before merge it.
Related issue:
#300
#1021
Task