Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

right to left support #10

Open
am2222 opened this issue Apr 6, 2018 · 14 comments
Open

right to left support #10

am2222 opened this issue Apr 6, 2018 · 14 comments

Comments

@am2222
Copy link

am2222 commented Apr 6, 2018

Hi,
Does this Ribbon supports Right to left languages such as Arabic?
thanks

@dukke
Copy link
Owner

dukke commented Apr 6, 2018

Hi,

No, not right now.

@am2222
Copy link
Author

am2222 commented Apr 7, 2018

@dukke thanks very much, is it possible to give me some hints about how can I do that? I am familiar with css but have no idea if I can use its related commands in javafx and make it right to left or not?
thanks

@dukke
Copy link
Owner

dukke commented Apr 7, 2018

Hi @am2222 !

First of all I don't really know how this is done. I've quickly searched the web but don't see any references about this in the microsoft ribbon..

Can you check and see if you find anything on how microsoft does this? I don't mean code wise, I mean how microsoft ribbon works in this case from a user point of view.

Thanks!

@am2222
Copy link
Author

am2222 commented Apr 7, 2018

@dukke hi,
You mean the way that a RTL ribbon is shown?Does it matter about the language? for example I have a few C# ribbon controls which are RTL I can share them if they are usefull

@dukke
Copy link
Owner

dukke commented Apr 7, 2018

Yes.

I would want to know how the official Microsoft Ribbon handles this..

Thanks,

@am2222
Copy link
Author

am2222 commented Apr 7, 2018

@dukke this is an example of RTL ribbon, But it is from devexpress C# controls but all the ribbons are just the same as this one
sketch

@dukke
Copy link
Owner

dukke commented Apr 7, 2018

Sounds good to me!

@am2222
Copy link
Author

am2222 commented Apr 7, 2018

@dukke Is there any chance to make it right to left? or if you please give me some hints I'll try by myself, I am new with javafx anyway

@dukke
Copy link
Owner

dukke commented Apr 7, 2018 via email

@am2222
Copy link
Author

am2222 commented Apr 7, 2018

@dukke thanks very much so if it is possible please tell me which files should be edited thanks

@dukke
Copy link
Owner

dukke commented Apr 7, 2018

I've been doing some testing and this actually seems quite easy to do.
I can do it myself or you could do it if you want to learn the basics for future contributions?

@dukke
Copy link
Owner

dukke commented Apr 7, 2018

A solution is:

  • Use NodeOrientation property from Node that is inhereted by the Ribbon class
  • Bind NodeOrientation property of Ribbon to RibbonTab instance in RibbonSkin class
  • Also change the layout for the QuickAccessBar according to NodeOrientation of Ribbon, in RibbonSkin

That's it, I think..

@dukke
Copy link
Owner

dukke commented Apr 7, 2018

Also a test class in the Test folder that shows a RTL ribbon working would be nice..

@am2222
Copy link
Author

am2222 commented Apr 8, 2018

@dukke thanks very much, I'll try to do it myself, I hope I can manage to do it. thanks very much

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants