Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added Spaceharpoon Polygon Nft Trades #6708

Closed
wants to merge 5 commits into from
Closed

Added Spaceharpoon Polygon Nft Trades #6708

wants to merge 5 commits into from

Conversation

sophie-analytics
Copy link
Contributor

Thank you for contributing to Spellbook 🪄

Update!

Please build spells in the proper subproject directory. For more information, please see the main readme, which also links to a GH discussion with the option to ask questions.

Contribution type

Please check the type of contribution this pull request is for:

  • New spell(s)
  • Adding to existing spell lineage
  • Bug fix

Note: You can safely discard any section below which doesn't apply based on selection above

For new spell(s)

If you are building new spell(s), please provide the following information:

  • Spell name(s): schema.table_name
  • Description: [Detailed description of the new spell(s) and their purpose]
  • Who are the new spell(s) for? [Internal team or general community]
  • How will the new spell(s) be used downstream? [Description of downstream usage]
  • Implementation details: [Information on how the spell(s) are implemented]
  • Test instructions: [How to test the new spell(s)]
  • Related issue(s): [Link to related issues, if any]

For adding to existing spell lineage

If you are adding to an existing spell lineage, please provide the following information:

  • Description: [Description of the changes made]

For bug fixes

If you are fixing a bug, please provide the following information:

  • Description: [Description of the bug fix]
  • Steps to reproduce: [How to reproduce the bug]
  • Implementation details: [Information on how the bug was fixed]
  • Test instructions: [How to test the fix]
  • Related issue(s): [Link to related issues, if any]

Additional information

Please provide any additional information that might help us review your pull request:

  • [Any additional information]

Thank you for your contribution!

@dune-eng
Copy link

Workflow run id 10820842183 approved.

@dune-eng
Copy link

Workflow run id 10820842347 approved.

@dune-eng
Copy link

Workflow run id 10821231099 approved.

@dune-eng
Copy link

Workflow run id 10821231297 approved.

@dune-eng
Copy link

Workflow run id 10864453706 approved.

@dune-eng
Copy link

Workflow run id 10864453785 approved.

@dune-eng
Copy link

Workflow run id 10864599312 approved.

@dune-eng
Copy link

Workflow run id 10864599336 approved.

@jeff-dude jeff-dude added ready-for-review this PR development is complete, please review dbt: nft covers the NFT dbt subproject labels Sep 17, 2024
0xRobin
0xRobin requested changes Sep 18, 2024
View reviewed changes
Copy link
Collaborator

@0xRobin 0xRobin left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not directly clear what you are trying to achieve in this PR.
If you want to integrate a new NFT marketplace into nft.trades you can take a look at this example PR #6559 where I added new marketplaces on Arbitrum Nova.
In short you should look to:

  • build out the base_trades model for the marketplace
  • integrate it with in the polygon base_trades model
    All of this is done in the nft dbt subproject (instead of the daily one)

Let me know if you have further questions or need assistance

macros/models/_sector/dex/iziswap_compatible_trade.sql
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is added by accident to this PR?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. It was a mistake

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you remove it?

dbt_subprojects/daily_spellbook/dbt_project.yml
Comment on lines +352 to +356

spaceharpoon:
+schema: spaceharpoon
polygon:
+schema: spaceharpoon_polygon
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

these lines are not needed (as we define the schema in the inline config in the models)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Noted!

dbt_subprojects/daily_spellbook/models/spaceharpoon/polygon/spaceharpoon_polygon_nft_trades.sql
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It does not look like you are using any events or calls that are specific to spaceharpoon, can you expand a bit on what you are trying to achieve in this PR?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you expand on your reasoning?
I don't think it is correct to just aggregate all token transfers from a transaction and use them to determine the price of an NFT transfer.
While I like the idea of a generic approach, a lot more work and testing would need to be done to make sure this is accurate.

@0xRobin 0xRobin added question Further information is requested WIP work in progress and removed ready-for-review this PR development is complete, please review labels Sep 18, 2024
@sophie-analytics
Copy link
Contributor Author

It's not directly clear what you are trying to achieve in this PR. If you want to integrate a new NFT marketplace into nft.trades you can take a look at this example PR #6559 where I added new marketplaces on Arbitrum Nova. In short you should look to:

  • build out the base_trades model for the marketplace
  • integrate it with in the polygon base_trades model
    All of this is done in the nft dbt subproject (instead of the daily one)

Let me know if you have further questions or need assistance

The problem I am trying to solve with this spell is that some nft sales are not being captured on the nft trades spell for polygon so I used a different methodology which solves the problem by capturing all the nft sales

@sophie-analytics
Copy link
Contributor Author

@0xRobin

0xRobin
0xRobin requested changes Oct 9, 2024
View reviewed changes
macros/models/_sector/dex/iziswap_compatible_trade.sql
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you remove it?

dbt_subprojects/daily_spellbook/models/spaceharpoon/polygon/spaceharpoon_polygon_nft_trades.sql
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you expand on your reasoning?
I don't think it is correct to just aggregate all token transfers from a transaction and use them to determine the price of an NFT transfer.
While I like the idea of a generic approach, a lot more work and testing would need to be done to make sure this is accurate.

@0xBoxer
Copy link
Collaborator

0xBoxer commented Oct 23, 2024

Due to a dbt version change, you need to merge main into your branch before the Github action runner runs successfully again.

@0xRobin 0xRobin marked this pull request as draft October 28, 2024 08:10
@jeff-dude jeff-dude closed this Nov 7, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Nov 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@0xRobin 0xRobin 0xRobin requested changes

Assignees

@0xRobin 0xRobin

Labels
dbt: nft covers the NFT dbt subproject question Further information is requested WIP work in progress
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@sophie-analytics @dune-eng @0xBoxer @0xRobin @jeff-dude