-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Daily Arbitrum Stablecoin Balances #6757
Conversation
Workflow run id 10929899636 approved. |
Workflow run id 10929899630 approved. |
I'm planning to test one chain and run through the rest of them in a separate PR if it looks good |
gm @Synthquest edit: |
Workflow run id 10944669542 approved. |
Workflow run id 10944670007 approved. |
Workflow run id 10946158848 approved. |
Workflow run id 10946158999 approved. |
@jeff-dude Chatgpt seems to think it timed out or hit some resource constraint 😅. On the previous run it was able to initialize the model but not able to complete the incremental run |
it could've been bad timing with other PRs running code at the same time, on the same cluster. you can always try to monitor that via the actions tab. let's see how this latest run goes. edit: |
Workflow run id 10950558230 approved. |
Workflow run id 10950558467 approved. |
Workflow run id 10952278872 approved. |
Workflow run id 10952278792 approved. |
@jeff-dude |
i don't think we need to limit ourselves on the stablecoins, it's a pretty small list. i haven't seen a commit here yet where you push a hardcoded date into the macro -- can you try that? |
Workflow run id 10961562717 approved. |
Workflow run id 10961562733 approved. |
I added in a more recent start date. For context this spell was able to fully compile in the token folder and was able to initialize in the daily folder on the first run but failed at the incremental test. shortening the time period seems to have worked as well. Not 100% sure this is what you meant though |
yeah, that commit looks like what i'm picturing. how do the results look? have you queried the CI output table to verify? if so, we can remove the short timeframe and prep for merge |
Awesome, I quickly did a check on:
For future guidance when we add more chains should we follow a similar approach (1 PR per chain with shortened timeframe for review)? |
Workflow run id 10965416955 approved. |
Workflow run id 10965417046 approved. |
@jeff-dude re-
|
you can submit multiple chains per PR, if using same macro. you would more than likely have to restrict timeframe to see it run, yes |
...rojects/daily_spellbook/models/_sector/stablecoins/arbitrum/stablecoins_arbitrum_sources.yml
Outdated
Show resolved
Hide resolved
Workflow run id 11001525630 approved. |
Workflow run id 11001525861 approved. |
Workflow run id 11001959864 approved. |
Workflow run id 11001960009 approved. |
Query is currently running tests but is set for the full time frame |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
think we're all good now 🙏
Thank you for contributing to Spellbook 🪄
Update!
Please build spells in the proper subproject directory. For more information, please see the main readme, which also links to a GH discussion with the option to ask questions.
Contribution type
Please check the type of contribution this pull request is for:
Note: You can safely discard any section below which doesn't apply based on selection above
For new spell(s)
If you are building new spell(s), please provide the following information:
This query is for anyone interested in network views of stablecoin balances
PR here: Static EVM Stablecoins #6723 (comment)
These tokens will utilize the balances_incremental_subset_daily macro to generate materialized daily tables of tokens listed ^
Following the same approach as here:
#6608
For adding to existing spell lineage
If you are adding to an existing spell lineage, please provide the following information:
For bug fixes
If you are fixing a bug, please provide the following information:
Additional information
Please provide any additional information that might help us review your pull request:
Thank you for your contribution!