Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add mantle & blast nft transfers to cross-chain spell #6784

Merged
merged 1 commit into from
Sep 24, 2024

Conversation

RantumBits
Copy link
Contributor

Thank you for contributing to Spellbook 🪄

Update!

Please build spells in the proper subproject directory. For more information, please see the main readme, which also links to a GH discussion with the option to ask questions.

Contribution type

Please check the type of contribution this pull request is for:

  • New spell(s)
  • Adding to existing spell lineage
  • Bug fix

Note: You can safely discard any section below which doesn't apply based on selection above


For new spell(s)

If you are building new spell(s), please provide the following information:

  • Spell name(s): schema.table_name
  • Description: [Detailed description of the new spell(s) and their purpose]
  • Who are the new spell(s) for? [Internal team or general community]
  • How will the new spell(s) be used downstream? [Description of downstream usage]
  • Implementation details: [Information on how the spell(s) are implemented]
  • Test instructions: [How to test the new spell(s)]
  • Related issue(s): [Link to related issues, if any]

For adding to existing spell lineage

If you are adding to an existing spell lineage, please provide the following information:

  • Description: [Description of the changes made]

For bug fixes

If you are fixing a bug, please provide the following information:

  • Description: [Description of the bug fix]
  • Steps to reproduce: [How to reproduce the bug]
  • Implementation details: [Information on how the bug was fixed]
  • Test instructions: [How to test the fix]
  • Related issue(s): [Link to related issues, if any]

Additional information

Please provide any additional information that might help us review your pull request:

  • [Any additional information]

Thank you for your contribution!

@dune-eng
Copy link

Workflow run id 10962735850 approved.

@dune-eng
Copy link

Workflow run id 10962762633 approved.

@RantumBits
Copy link
Contributor Author

RantumBits commented Sep 20, 2024

@jeff-dude - this run got further than in #6772, but still timed-out during the incremental test stage

@jeff-dude
Copy link
Member

definitely interesting that it gets hung up on the tests, which makes me think querying the table in general is slow. i think we're good to merge, since the models themselves run fine, but should take a look at that test and why its so slow

@jeff-dude jeff-dude self-assigned this Sep 20, 2024
@jeff-dude jeff-dude added the in review Assignee is currently reviewing the PR label Sep 20, 2024
@RantumBits RantumBits mentioned this pull request Sep 20, 2024
3 tasks
@RantumBits
Copy link
Contributor Author

sounds good. i'll mark as 'ready for review'. lmk if anything else needed here.

definitely interesting that it gets hung up on the tests, which makes me think querying the table in general is slow. i think we're good to merge, since the models themselves run fine, but should take a look at that test and why its so slow

@RantumBits RantumBits marked this pull request as ready for review September 23, 2024 16:47
@jeff-dude jeff-dude added ready-for-merging and removed in review Assignee is currently reviewing the PR labels Sep 23, 2024
@jeff-dude jeff-dude merged commit 3e11e53 into duneanalytics:main Sep 24, 2024
1 of 2 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Sep 24, 2024
@RantumBits RantumBits deleted the nft branch September 26, 2024 16:28
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants