Removed usage of get_content_node_parents (#9926)

* Removed usage of get_content_node_parents * front linter
dust-tt · Jan 13, 2025 · 4f51273 · 4f51273
1 parent eef1178
commit 4f51273
Show file tree

Hide file tree

Showing 4 changed files with 6 additions and 117 deletions.
diff --git a/connectors/src/api/get_content_node_parents.ts b/connectors/src/api/get_content_node_parents.ts
diff --git a/connectors/src/api_server.ts b/connectors/src/api_server.ts
@@ -13,7 +13,6 @@ import {
   getConnectorsAPIHandler,
 } from "@connectors/api/get_connector";
 import { getConnectorPermissionsAPIHandler } from "@connectors/api/get_connector_permissions";
-import { getContentNodesParentsAPIHandler } from "@connectors/api/get_content_node_parents";
 import { getContentNodesAPIHandler } from "@connectors/api/get_content_nodes";
 import { pauseConnectorAPIHandler } from "@connectors/api/pause_connector";
 import { resumeConnectorAPIHandler } from "@connectors/api/resume_connector";
@@ -112,11 +111,6 @@ export function startServer(port: number) {
     "/connectors/:connector_id/permissions",
     getConnectorPermissionsAPIHandler
   );
-  app.post(
-    // must be POST because of body
-    "/connectors/:connector_id/content_nodes/parents",
-    getContentNodesParentsAPIHandler
-  );
   app.post(
     // must be POST because of body
     "/connectors/:connector_id/content_nodes",

diff --git a/front/temporal/tracker/activities.ts b/front/temporal/tracker/activities.ts
@@ -11,6 +11,7 @@ import {
   Err,
   GPT_4O_MODEL_CONFIG,
   Ok,
+  removeNulls,
 } from "@dust-tt/types";
 import { Context } from "@temporalio/activity";
 import _ from "lodash";
@@ -484,18 +485,19 @@ async function getTrackersToRun(
       config.getConnectorsAPIConfig(),
       logger
     );
-    const parentsResult = await connectorsAPI.getContentNodesParents({
+    const parentsResult = await connectorsAPI.getContentNodes({
       connectorId: dataSource.connectorId,
       internalIds: [documentId],
+      includeParents: true,
     });
     if (parentsResult.isErr()) {
       throw parentsResult.error;
     }
 
-    docParentIds = [
+    docParentIds = removeNulls([
       documentId,
-      ...parentsResult.value.nodes.flatMap((node) => node.parents),
-    ];
+      ...parentsResult.value.nodes.flatMap((node) => node.parentInternalIds),
+    ]);
   }
 
   return TrackerConfigurationResource.fetchAllWatchedForDocument(auth, {

diff --git a/types/src/front/lib/connectors_api.ts b/types/src/front/lib/connectors_api.ts
@@ -497,36 +497,6 @@ export class ConnectorsAPI {
     return this._resultFromResponse(res);
   }
 
-  async getContentNodesParents({
-    connectorId,
-    internalIds,
-  }: {
-    connectorId: string;
-    internalIds: string[];
-  }): Promise<
-    ConnectorsAPIResponse<{
-      nodes: {
-        internalId: string;
-        parents: string[];
-      }[];
-    }>
-  > {
-    const res = await this._fetchWithError(
-      `${this._url}/connectors/${encodeURIComponent(
-        connectorId
-      )}/content_nodes/parents`,
-      {
-        method: "POST",
-        headers: this.getDefaultHeaders(),
-        body: JSON.stringify({
-          internalIds,
-        }),
-      }
-    );
-
-    return this._resultFromResponse(res);
-  }
-
   async getContentNodes<IncludeParents extends boolean>({
     connectorId,
     includeParents,