Speed up sourceUrl backfill scripts by leveraging indexes
#10039
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aubin-tchoi
force-pushed
the
update-backfil-scripts
branch
from
33b757c to
80f719e
Compare
philipperolet
approved these changes
Jan 16, 2025
| @@ -44,10 +48,15 @@ async function backfillFolders( | |||
| `SELECT id, "internalId", "url" | |||
| FROM webcrawler_folders | |||
| WHERE id > :lastId | |||
| AND "connectorId" = :connectorId -- does not leverage any index, we'll see if too slow or not | |||
There was a problem hiding this comment.
yep likely not used but still good to have there
| lastId = rows[rows.length - 1].id; | ||
| } while (rows.length === BATCH_SIZE); | ||
| } | ||
| ) {} |
There was a problem hiding this comment.
nit: you could remove
| FROM (SELECT unnest(ARRAY [:nodeIds]::text[]) as node_id, | ||
| unnest(ARRAY [:urls]::text[]) as url) urls | ||
| WHERE data_sources_nodes.node_id = urls.node_id | ||
| AND data_sources_nodes.data_source = :dataSourceId;`, |
There was a problem hiding this comment.
pretty sure sql is smart enough to use the index despite the order being backwards, but only ~83% sure so keep an 👁️ 🙂
…id) and not (node_id, data_source)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
data_sources_documents) and leveraging an index.Risk
n/a
Deploy Plan
no deploy