Subscription page: Display pricing table is current plan is a free one #10047
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flvndvd
reviewed
Jan 17, 2025
| display="subscribe" | ||
| /> | ||
| </div> | ||
| {displayPricingTable && ( |
There was a problem hiding this comment.
Won't this will also display the pricing table for entreprise plans?
There was a problem hiding this comment.
Nope enterprise plans have a stripeSubscriptionId since payment is involved!
There was a problem hiding this comment.
(You can't create an enterprise sub without a stripeSubscriptionId)
There was a problem hiding this comment.
Ah yeah misread the === null.
flvndvd
approved these changes
Jan 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The goal of this PR is to allow the workspaces in Free Pilot to subscribe autonomously on Pro plan.
I could have whitelisted those plan code but I figured out testing that the current active subscription does not involve payment with Stripe will be more future proof, we won't have to maintain a list of code.
Review with hidden whitespaces: https://github.com/dust-tt/dust/pull/10047/files?diff=split&w=1
Risk
Can be rolled back.
Deploy Plan
Deploy front.