Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[sparkle] - enh: Sheet add side prop #10054

Merged
merged 2 commits into from
Jan 17, 2025
Merged

[sparkle] - enh: Sheet add side prop #10054

merged 2 commits into from
Jan 17, 2025

Conversation

JulesBelveze
Copy link
Contributor

Description

This PR aims at adding a side prop the Sheet component.

Risk

Low

Deploy Plan

  • Publish sparkle

 - Implemented support for sheets to animate from different sides: top, bottom, left, right
 - Updated SheetContent component to accept a 'side' prop controlling the slide-in behavior
 - Incremented the version number to prepare for new release of the @dust-tt/sparkle package
Copy link
Contributor

@aubin-tchoi aubin-tchoi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JulesBelveze JulesBelveze merged commit 2b5aaa8 into main Jan 17, 2025
3 checks passed
@JulesBelveze JulesBelveze deleted the sparkle/sheet-side branch January 17, 2025 10:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants