[front] Shadow read content nodes from core and compute diff
#10061
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aubin-tchoi
force-pushed
the
shadow-read
branch
from
77dc6f3 to
83fdfe2
Compare
aubin-tchoi
force-pushed
the
shadow-read
branch
from
83fdfe2 to
a603a0f
Compare
front/lib/api/data_source_view.ts
Outdated
|
|
||
| // shadow read from core | ||
| const coreContentNodesRes = | ||
| await getContentNodesForManagedDataSourceViewFromCore( |
There was a problem hiding this comment.
what about turning that call into getContentNodesForDatasourceViewCore doing both static & managed?
There was a problem hiding this comment.
yes indeed, next step would have been to move anyway!
…odesForDataSourceViewFromCore and handle static data sources altogether
philipperolet
approved these changes
Jan 17, 2025
| "[CoreNodes] Could not fetch content nodes from core" | ||
| ); | ||
| } else if (coreContentNodesRes.isOk()) { | ||
| if (coreContentNodesRes.value.total !== contentNodesResult.total) { |
There was a problem hiding this comment.
nit: core defaults to 100 results while connectors is not paginated (returns everything)
I suggest switching to 250 in searchNodes from the core call for now to limit the logs on count mismatch that are just related to that (since it's not actually something to fix)
|
We are probably going to get a lot of false positives, notably on |
tdraier
pushed a commit
that referenced
this pull request
Jan 20, 2025
* add shadow read and content nodes comparison * add a log of extra core nodes * fix the diff for arrays (parents) * pass the parentsIn when no internalIds are passed * turn getContentNodesForManagedDataSourceViewFromCore into getContentNodesForDataSourceViewFromCore and handle static data sources altogether * 📝 * bump the limit to 250 on searchNodse
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Risk
Deploy Plan