Upg: allow selecting specific files in folders for assistants #10071
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
philipperolet
approved these changes
Jan 17, 2025
| // Folders with viewType "documents" are always considered leaf items. | ||
| // For viewType "tables", folders are not leaf items because users need to select a specific table. | ||
| return !isFolder(ds) || viewType === "tables"; | ||
| return true; |
There was a problem hiding this comment.
nit: the function could become just !!ds
There was a problem hiding this comment.
Yeah, I figured we keep it for future ease of usage if we want to disallow expand again for something else.
Fraggle
deleted the
1974-allow-configuring-an-assistant-with-specific-files-from-a-folder
branch
tdraier
pushed a commit
that referenced
this pull request
Jan 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Now that folder documents have their parents correctly set, we can select them individually for assistant !
Risk
Low, worst case, missing files when expanding.
Deploy Plan
Deploy
front