Add support for Slack mentions #1976
Conversation
connectors/src/lib/edit_distance.ts
Outdated
| @@ -0,0 +1,41 @@ | |||
| // Returns the Levenshtein distance between str1 and str2. | |||
There was a problem hiding this comment.
why not use eg https://github.com/gustf/js-levenshtein ?
There was a problem hiding this comment.
not a big fan of having this code in this repo, since It doesn't look great due to all these "expect error"
There was a problem hiding this comment.
ok I will use https://github.com/words/levenshtein-edit-distance (looks more recently maintained + the doc says it's fully typed).
There was a problem hiding this comment.
Ok the code of this one is not typed neither. I think it's fine to have that. I could not find one properly typed implementation.
| distance: distance, | ||
| }); | ||
| } | ||
| scores.sort((a, b) => { |
There was a problem hiding this comment.
nit: maybe no need to sort the whole array if we only need the max ?
There was a problem hiding this comment.
Agreed we can store the max as we push. But no big deal
There was a problem hiding this comment.
stored the max. thanks.
| if (mentions.length === 0) { | ||
| mentions.push({ assistantId: "dust", assistantName: "dust" }); | ||
| } | ||
| // for now we support only one mention. |
There was a problem hiding this comment.
Oh right only streaming answer 👍
connectors/src/lib/edit_distance.ts
Outdated
| @@ -0,0 +1,41 @@ | |||
| // Returns the Levenshtein distance between str1 and str2. | |||
| distance: distance, | ||
| }); | ||
| } | ||
| scores.sort((a, b) => { |
There was a problem hiding this comment.
Agreed we can store the max as we push. But no big deal
No description provided.