Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Member onboarding video #2123

Merged
merged 1 commit into from
Oct 17, 2023
Merged

Member onboarding video #2123

merged 1 commit into from
Oct 17, 2023

Conversation

PopDaph
Copy link
Contributor

@PopDaph PopDaph commented Oct 13, 2023

Review with hidden whitespaces: https://github.com/dust-tt/dust/pull/2123/files?diff=split&w=1

Notes:

  • it's on the welcome page directly because @Duncid wants no change in the animation.
  • not ready to be merged cause we don't have the video yet
  • YoutubeIframe directly in the component cause it's easier to read and used only here but I can move it on a new file in /front/components/youtube.tsx if you think it's better!

Screenshots

(I'm trying to deploy on edge to provide a demo)

Ok can't deploy on Front edge, tant pis !
Capture d’écran 2023-10-13 à 18 06 29

Capture d’écran 2023-10-13 à 18 06 43

@PopDaph PopDaph requested a review from spolu October 13, 2023 16:01
@PopDaph
Copy link
Contributor Author

PopDaph commented Oct 16, 2023

@spolu Time to review this small one? 🙏🏻
So that I can merge as soon as we have the video 🙇🏻‍♀️

@PopDaph PopDaph merged commit ab36d4e into main Oct 17, 2023
2 of 4 checks passed
@PopDaph PopDaph deleted the onboarding-video branch October 17, 2023 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants