[.github] - infra: new connectors deploy workflow #8661
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…structure - Introduce workflow_dispatch trigger with a configurable input for deploying to the 'us-central1' region - Implement concurrency control to manage deployment processes and prevent collisions - Authenticate with Google Cloud and set up the Cloud SDK for deployment tasks - Build a Docker image using Cloud Build and a custom script, with parameters for image name and Dockerfile path - Generate a GitHub App token dynamically for use in the workflow - Enable triggering of a downstream repository's workflow using a repository dispatch event with a custom payload including the region and image tag
…ment - Switch to using specific app ID and private key for infra deployment - Correct the environment variable used for the GitHub token in the dispatch event trigger
- Ensure the `cloud-build.sh` script uses the correct relative working directory by adding a leading `./` to the path configuration
- Changed the GitHub App ID reference to use secrets for enhanced security and better management of sensitive data - This update ensures that the App ID is not exposed in the workflow file, aligning with best practices for credential storage
flvndvd
reviewed
Nov 15, 2024
| ./k8s/cloud-build.sh \ | ||
| --image-name=connectors \ | ||
| --dockerfile-path=./connectors/Dockerfile \ | ||
| --working-dir=. \ |
There was a problem hiding this comment.
Suggested change
| --working-dir=. \ | |
| --working-dir=./ \ |
| id: generate-token | ||
| uses: actions/create-github-app-token@v1 | ||
| with: | ||
| app-id: ${{ vars.INFRA_DISPATCH_APP_ID }} |
There was a problem hiding this comment.
Suggested change
| app-id: ${{ vars.INFRA_DISPATCH_APP_ID }} | |
| app-id: ${{ secrets.INFRA_DISPATCH_APP_ID }} |
flvndvd
approved these changes
Nov 15, 2024
Duncid
pushed a commit
that referenced
this pull request
Nov 15, 2024
* [.github] - feature: add manual workflow dispatch for deploying infrastructure - Introduce workflow_dispatch trigger with a configurable input for deploying to the 'us-central1' region - Implement concurrency control to manage deployment processes and prevent collisions - Authenticate with Google Cloud and set up the Cloud SDK for deployment tasks - Build a Docker image using Cloud Build and a custom script, with parameters for image name and Dockerfile path - Generate a GitHub App token dynamically for use in the workflow - Enable triggering of a downstream repository's workflow using a repository dispatch event with a custom payload including the region and image tag * [.github] - fix: update secrets and app ID for connector infra deployment - Switch to using specific app ID and private key for infra deployment - Correct the environment variable used for the GitHub token in the dispatch event trigger * [.github] - fix: correct working directory path in GitHub Actions config - Ensure the `cloud-build.sh` script uses the correct relative working directory by adding a leading `./` to the path configuration * [.github] - fix: use secret for INFRA_DISPATCH_APP_ID in GitHub Actions - Changed the GitHub App ID reference to use secrets for enhanced security and better management of sensitive data - This update ensures that the App ID is not exposed in the workflow file, aligning with best practices for credential storage
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR aims at adding a workflow to trigger the connectors deployment from the
dust-infrarepository.Risk
Deploy Plan