[front] - chore(sidebarmenu): polish #8920
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Remove left padding from the conversation sidebar container for a cleaner layout - Add horizontal padding within the scroll area for better content spacing and readability
…in SidebarMenu - Consolidated action buttons for multi-select mode to improve accessibility and interface consistency - Added a shadow box style to enhance visual separation of action buttons from conversation list
…ering of sidebar menu actions - Simplified the conditionals by separating the multi-select and default action views into distinct blocks - Removed redundant classes and elements to clean up the UI structure for better maintainability
…port from SidebarMenu - Cleanup of SidebarMenu component by removing the import statement for Separator which is no longer used
- Replace inline shadow styles with a `shadow-fade` utility class for consistency and maintainability - Apply the new `shadow-fade` class to elements within the `SidebarMenu.tsx` file
…tyling for SidebarMenu - Replace `shadow-fade` with `shadow-tale` in SidebarMenu for multi-select and action buttons - Remove deprecated `shadow-fade` styling from global.css [front/tailwind.config] - feature: add new 'tale' box-shadow to tailwind configuration - Introduce a new `tale` box-shadow definition to the TailwindCSS configuration for future use in styling
- Ensure consistent ordering of CSS classes for improved readability and adherence to styling guidelines - Modify the positioning of 'shadow-tale' to be the last class in the class list for sidebar elements
overmode
pushed a commit
that referenced
this pull request
Nov 27, 2024
* [front] - fix: adjust conversation sidebar padding and scroll area - Remove left padding from the conversation sidebar container for a cleaner layout - Add horizontal padding within the scroll area for better content spacing and readability * [assistant/conversation] - refactor: streamline multi-select actions in SidebarMenu - Consolidated action buttons for multi-select mode to improve accessibility and interface consistency - Added a shadow box style to enhance visual separation of action buttons from conversation list * [front/components/assistant/conversation] - refactor: streamline rendering of sidebar menu actions - Simplified the conditionals by separating the multi-select and default action views into distinct blocks - Removed redundant classes and elements to clean up the UI structure for better maintainability * [front/assistant/conversation] - refactor: remove unused Separator import from SidebarMenu - Cleanup of SidebarMenu component by removing the import statement for Separator which is no longer used * [front] - refactor: streamline shadow styling in SidebarMenu components - Replace inline shadow styles with a `shadow-fade` utility class for consistency and maintainability - Apply the new `shadow-fade` class to elements within the `SidebarMenu.tsx` file * [front/components/assistant/conversation] - refactor: update shadow styling for SidebarMenu - Replace `shadow-fade` with `shadow-tale` in SidebarMenu for multi-select and action buttons - Remove deprecated `shadow-fade` styling from global.css [front/tailwind.config] - feature: add new 'tale' box-shadow to tailwind configuration - Introduce a new `tale` box-shadow definition to the TailwindCSS configuration for future use in styling * [front] - fix: adjust shadow-tale CSS class ordering in SidebarMenu - Ensure consistent ordering of CSS classes for improved readability and adherence to styling guidelines - Modify the positioning of 'shadow-tale' to be the last class in the class list for sidebar elements
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR polishes the
SidebarMenuto adjust padding and add a shadow effect to scrollable content when disappearing under the div contain the buttons.Risk
Low
Deploy Plan
Deploy
front