[KW-Search] Fix sql for nodes tables creation #8926
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Description --- Migration did not work because quotes were needed for the reserved keyword 'table' Although not optimal in general as a column name, here it's the best naming, consistent with data_source / document / folder, and avoiding the clash with table_id (which is a string id) Risk --- na Deploy --- migration on prodbox deploy core
spolu
approved these changes
Nov 26, 2024
overmode
pushed a commit
that referenced
this pull request
Nov 27, 2024
* [KW-Search] Fix sql for nodes tables creation Description --- Migration did not work because quotes were needed for the reserved keyword 'table' Although not optimal in general as a column name, here it's the best naming, consistent with data_source / document / folder, and avoiding the clash with table_id (which is a string id) Risk --- na Deploy --- migration on prodbox deploy core * quotes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Migration did not work because quotes were needed for the reserved keyword 'table'
Although not optimal in general as a column name, here it's the best naming, consistent with data_source / document / folder, and avoiding the clash with table_id (which is a string id)
Risk
na
Deploy
migration on prodbox
deploy core