Remove unused dependencies #9223
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tdraier
added a commit
that referenced
this pull request
Dec 9, 2024
spolu
reviewed
Dec 9, 2024
| "hot-shots": "^10.0.0", | ||
| "io-ts": "^2.2.20", | ||
| "io-ts-reporters": "^2.0.1", | ||
| "io-ts-types": "^0.5.19", |
There was a problem hiding this comment.
io-ts-types is not imported in the code except in dust-tt/types, so I'm puzzled.
Trying to repro/config.
spolu
reviewed
Dec 9, 2024
| "react-textarea-autosize": "^8.4.0", | ||
| "redis": "^4.6.8", | ||
| "rehype-katex": "^7.0.0", |
There was a problem hiding this comment.
quite suspicious that this is really unused along with all remark/rehype plugins
There was a problem hiding this comment.
(some were moved to sparkle with the markdown component but there isn't a 1-1 mapping in particular the maths related ones)
There was a problem hiding this comment.
From what I can see, it's only used here
Fraggle
added a commit
that referenced
this pull request
Dec 9, 2024
Fraggle
added a commit
that referenced
this pull request
Dec 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Remove all dependencies flagged as "unused" by depcheck + manual search.
Risk
Medium, relying on typechecking and build working. Testing in front-edge.
Deploy Plan
Deploy
front-edge, test, then Deploy tofront