Add confluence to parents migration script #9287
Conversation
| return [...parents, ...parents.map(convertConfluenceOldIdToNewId)]; | ||
| } | ||
| // checking that we got a mix of old and new IDs, with the old ones matching the new ones | ||
| for (const parent of parents) { |
There was a problem hiding this comment.
you're just checking the validity of the code above here no?
There was a problem hiding this comment.
i'm checking the validity of the new code in connectors that upserts the parents
| confluence: { | ||
| transformer: (nodeId, parents) => { | ||
| // case where we got old IDs exclusively: we add the new IDs to them | ||
| if ( |
There was a problem hiding this comment.
In that case why not just do a ...parents, ...parents.map() and then uniq (so that it can be run mulitple times on the same doc?)
There was a problem hiding this comment.
if there is some kind of inconsistency with what we upsert we won't know about it no?
ofc if i run the script and see assert errors at the first line i'll just change that to what you suggest :p
There was a problem hiding this comment.
fyi changed all of that to make it idempotent: I turn all old IDs into new ones and then do a unique
# Conflicts: # front/migrations/20241211_parents_migrator.ts
| confluence: { | ||
| transformer: (nodeId, parents) => { | ||
| return [ | ||
| ...new Set([...parents, ...parents.map(convertConfluenceOldIdToNewId)]), |
There was a problem hiding this comment.
We want the mapped parents first so that parents[0] = nodeId right?
Description
Risk
Deploy Plan
n/a