Remove new conversation input bar animation #9534
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spolu
commented
Dec 19, 2024
| @@ -22,12 +22,14 @@ import { classNames } from "@app/lib/utils"; | |||
|
|
|||
| export function ConversationTitle({ | |||
| owner, | |||
| conversationId, | |||
There was a problem hiding this comment.
We can have a conversationId before we have a conversation (shallow page change before the swr hook is executed)
spolu
commented
Dec 19, 2024
| @@ -231,12 +231,12 @@ export function ConversationContainer({ | |||
| }); | |||
| } else { | |||
| // We start the push before creating the message to optimize for instantaneity as well. | |||
| setActiveConversationId(conversationRes.value.sId); | |||
| void router.push( | |||
| await router.push( | |||
There was a problem hiding this comment.
required so that we snap once the shallow URL change is done so that everyone snap at the same time (title in, conversation in, assistant out)
fontanierh
approved these changes
Dec 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The Input Bar translation to the bottom of the conversation going from new to a conversation is not hardware accelerated. It's tricky to hardware accelerate (though possible) as it requires using translate but it would mean computing various value that we don't today as we rely on the layout of the page and the stickyness to the bottom of the input bar.
This PR proposes to remove all these transitions as they are clearly buggy and visually not appealing in favor of snapping things around immediately (as does chatGPT probably for the same reasons).
Risk
Low
Deploy Plan
fonrt