Fixing padding error #9656
Merged
Fixing padding error #9656
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tdraier
reviewed
Dec 30, 2024
|
Actually the only place where we don't want the padding is from ConversationContainer ? |
Co-authored-by: Thomas Draier <thomas@dust.tt>
Probably yes. I don't understand how to do it though. |
tdraier
approved these changes
Dec 30, 2024
overmode
pushed a commit
that referenced
this pull request
Jan 6, 2025
* Fixing padding error * zIndex problem fix :q * Update front/components/sparkle/AppLayout.tsx Co-authored-by: Thomas Draier <thomas@dust.tt> * patch * Remove default value --------- Co-authored-by: Thomas Draier <thomas@dust.tt>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Re-inserted the line.
Added a hasTopPadding prop, but couldn't fnd where to make use of it to remove the padding from new convo screen.
Risk
n/a
Deploy Plan
merge