Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Zendesk) - organize ticket and article internal IDs per brand #9693

Closed
wants to merge 11 commits into from

Conversation

aubin-tchoi
Copy link
Contributor

@aubin-tchoi aubin-tchoi commented Jan 2, 2025

Description

  • Close [Zendesk] Add the brandId in the internal IDs for tickets and articles #9691
  • Close #1870
  • Update all the methods that fetch Zendesk tickets, articles or categories by ID to also filter on the brand ID.
  • Add the corresponding indexes.
  • Change the internal ID for single tickets and articles to include the brand ID.
    • No migration required in front: single tickets and articles are never passed as parents.
    • Migration required in core: going to backfill new documents with the new ID (see deploy plan).

Risk

  • Moderate risk of breaking the search on Zendesk data sources, relies on a carefully executed migration plan.

Deploy Plan

  • Run the backfill.
  • Run the migration that adds the indexes.
  • Stop all Zendesk connectors.
  • Deploy connectors.
  • Resume all Zendesk connectors.
  • Run the cleanup script.

@aubin-tchoi
Copy link
Contributor Author

gonna do it in a different way, gonna cherry pick from this but won't merge

@aubin-tchoi aubin-tchoi closed this Jan 2, 2025
@aubin-tchoi aubin-tchoi deleted the fix-fetch-ticket branch January 2, 2025 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Zendesk] Add the brandId in the internal IDs for tickets and articles
1 participant