Extension: Disable share buttons when domain is blackisted #9694
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
we should also handle the right click , all actions must be disabled |
|
Indeed, good catch !!!! |
tdraier
approved these changes
Jan 2, 2025
| setCurrentDomain(url.hostname); | ||
| } | ||
| } catch (e) { | ||
| console.error("Invalid URL:", e); |
There was a problem hiding this comment.
we don't want to log an error here (can be a normal behaviour if we are on chrome:// urls for example)
There was a problem hiding this comment.
Chrome urls does not raise errors so if there's an error I think we want to know! But you're right, I still added a commit to handle chrome urls to also disable the buttons when we're on Chrome
PopDaph
force-pushed
the
extension-blacklist-domains
branch
from
f1a796e to
0a77ff6
Compare
PopDaph
force-pushed
the
extension-blacklist-domains
branch
from
0a77ff6 to
c72dff6
Compare
|
Will handle the right click on my next PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Risk
Can be rolled back.
Deploy Plan
1/ Merge the base branch PR #9688.
2/ Publish the SDK package.
3/ Bump the extension package on the extension.