Slack Auto-Read Channel Pattern with Multiple Spaces #9701
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flvndvd
commented
Jan 2, 2025
| @@ -0,0 +1,2 @@ | |||
| -- Migration created on Jan 02, 2025 | |||
There was a problem hiding this comment.
Better reviewed with hidden whitespaces (here).
| const searchParams = new URLSearchParams({ | ||
| kind: "custom", | ||
| vaultId: p.spaceId, | ||
| dataSourceId: connector.dataSourceId, |
There was a problem hiding this comment.
🚗 case typo prevented this code to work before.
| }); | ||
|
|
||
| export type SlackConfiguration = t.TypeOf<typeof SlackConfigurationTypeSchema>; |
There was a problem hiding this comment.
Removing this type which was duplicated.
JulesBelveze
approved these changes
Jan 2, 2025
| this.connectorId | ||
| ); | ||
| if (!slackConfig) { | ||
| return new Err(new Error("autoReadChannelPattern is not deprecated")); |
There was a problem hiding this comment.
Suggested change
| return new Err(new Error("autoReadChannelPattern is not deprecated")); | |
| return new Err(new Error("autoReadChannelPattern is now deprecated")); |
| @@ -725,12 +747,23 @@ export class SlackConnectorManager extends BaseConnectorManager<SlackConfigurati | |||
| } | |||
| return new Ok(botEnabledRes.value.toString()); | |||
| } | |||
|
|
|||
| case "autoReadChannelPattern": { | |||
There was a problem hiding this comment.
Let's deprecate as well?
There was a problem hiding this comment.
Will need to be done in a clean up PR otherwise it prevents loading Poke.
flvndvd
added
the
migration-ack
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR resolves https://github.com/dust-tt/tasks/issues/1616.
It lets Dust employees whitelist channel patterns that should automatically be added in a specific spaces. This feature was not working with spaces before.
It adds a new column that will store a
JSONBobject representing patterns with their associated space id. One pattern can exist several times and they will be added in all the associated data source view.Poke View:
Risks
Worst-case it breaks the auto-join channel approach. Safe to rollback.
Deploy Plan