Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(Zendesk) - use the new internal IDs in content nodes #9711

Merged
merged 4 commits into from
Jan 2, 2025
Merged

fix(Zendesk) - use the new internal IDs in content nodes #9711

merged 4 commits into from
Jan 2, 2025

Conversation

aubin-tchoi
Copy link
Contributor

Description

Risk

  • theoretically could break the assistant builder and space configuration since it changes the content nodes but in practice internal IDs are always read using the generic function getIdsFromInternalId so every call site is covered at once

Deploy Plan

  • Deploy connectors.

spolu
spolu approved these changes Jan 2, 2025
View reviewed changes
Copy link
Contributor

@spolu spolu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks very reasonable

@aubin-tchoi aubin-tchoi merged commit 155c08a into main Jan 2, 2025
3 checks passed
@aubin-tchoi aubin-tchoi deleted the zendesk-fix-content-nodes branch January 2, 2025 17:17
aubin-tchoi added a commit that referenced this pull request Jan 2, 2025
@aubin-tchoi
Revert "fix(Zendesk) - use the new internal IDs in content nodes (#9711…
41ddcf1 
…)"

This reverts commit 155c08a.
@aubin-tchoi aubin-tchoi mentioned this pull request Jan 2, 2025
Merged
aubin-tchoi added a commit that referenced this pull request Jan 2, 2025
@aubin-tchoi
Revert "fix(Zendesk) - use the new internal IDs in content nodes (#9711…
50e1ef6 
…)" (#9714)

This reverts commit 155c08a.
@aubin-tchoi aubin-tchoi mentioned this pull request Jan 3, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spolu spolu spolu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aubin-tchoi @spolu