Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Revert "fix(Zendesk) - use the new internal IDs in content nodes"" #9723

Merged

Conversation

aubin-tchoi
Copy link
Contributor

Description

Original description

Risk

  • theoretically could break the assistant builder and space configuration since it changes the content nodes but in practice internal IDs are always read using the generic function getIdsFromInternalId so every call site is covered at once

Deploy Plan

  • Deploy connectors.

@aubin-tchoi aubin-tchoi requested a review from spolu January 3, 2025 09:22
@aubin-tchoi aubin-tchoi merged commit 1926e48 into main Jan 3, 2025
3 checks passed
@aubin-tchoi aubin-tchoi deleted the revert-9714-revert-9711-zendesk-fix-content-nodes branch January 3, 2025 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants