Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Zendesk) - render the plain body in tickets instead of the body #9751

Merged
merged 1 commit into from
Jan 3, 2025

Conversation

aubin-tchoi
Copy link
Contributor

Description

  • We got RangeError: Maximum call stack size exceeded when converting the body of ticket comments from HTML to markdown.
  • The content of the ticket comments turned out to contain html elements that cause an infinite recursion.
  • Instead of relying on the body field of the comments, which contain some html content, this PR proposes to use the plain_body, which is an HTML-free version.
  • On the examples studied, the extra HTML content did not bring significant semantic information, the plain_body is mostly a restructuration of the same information.

Risk

  • Low

Deploy Plan

  • Deploy connectors.

@aubin-tchoi aubin-tchoi requested review from tdraier and PopDaph and removed request for tdraier January 3, 2025 16:50
Copy link
Contributor

@PopDaph PopDaph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻

@aubin-tchoi aubin-tchoi merged commit 668c871 into main Jan 3, 2025
3 checks passed
@aubin-tchoi aubin-tchoi deleted the fix-zendesk-turndown branch January 3, 2025 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants