Removed usage of get_content_node_parents #9926
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aubin-tchoi
approved these changes
Jan 13, 2025
Comment on lines
+497
to
+500
| docParentIds = removeNulls([ | ||
| documentId, | ||
| ...parentsResult.value.nodes.flatMap((node) => node.parents), | ||
| ]; | ||
| ...parentsResult.value.nodes.flatMap((node) => node.parentInternalIds), | ||
| ]); |
There was a problem hiding this comment.
we might want to keep unique values no?
There was a problem hiding this comment.
As seen irl, this should be safe because we only get the parents for a single node 👍
overmode
deleted the
9863-connectorsfront-kill-connector-endpoint-get_content_node_parents
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
get_content_node_parentsendpoint and all its calls (only one in tracker)Risk
Low, break tracker
Deploy Plan
Deploy Front, then deploy Connectors