[content-nodes] Add a log and update the doc for lastUpdatedAt
#9969
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
aubin-tchoi
added
the
documentation-ack
| @@ -308,6 +308,12 @@ async function handler( | |||
| mimeType = r.data.mime_type; | |||
| title = r.data.title; | |||
| } else { | |||
| // TODO(content-node): get rid of this once the use of timestamp columns in core has been rationalized | |||
| logger.info( | |||
There was a problem hiding this comment.
we should log only if set, right?
There was a problem hiding this comment.
also do we have the workspace id in the log? important if we need to warn them we change the field
There was a problem hiding this comment.
removed the log if timestamp not set, added the workspace ID and dataSource sId
front/public/swagger.json
Outdated
| @@ -3296,8 +3296,8 @@ | |||
| }, | |||
| "/api/v1/w/{wId}/spaces": { | |||
| "get": { | |||
| "summary": "List Workspace Spaces", | |||
| "description": "Retrieves a list of spaces for the authenticated workspace.", | |||
| "summary": "List Spaces accessible.", | |||
There was a problem hiding this comment.
nit: english: "List available spaces"
aubin-tchoi
force-pushed
the
last-updated-at
branch
from
69f421a to
2e9d9cc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
/api/v1to discourage the use of timestamp in upserted documents/tables.Risk
Deploy Plan