feat(cb2-10084): Added scanner job and sonarqube to dev dependencies #87
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JoshCarter-ops
requested review from
shivangidas,
me-matt and
hamiltonrossbjss
me-matt
requested changes
Dec 5, 2023
| run: | | ||
| npm run coverage && \ | ||
| npm run sonar-scanner -- \ | ||
| -Dsonar.host.url=${{ env.SONARQUBE_GHA_URL }} \ |
There was a problem hiding this comment.
No space, JVM parameter format.
| @@ -40,7 +40,7 @@ | |||
| "node-yaml": "4.0.1", | |||
| "path-parser": "^6.1.0", | |||
| "reflect-metadata": "^0.1.13", | |||
| "serverless-dynamodb": "0.2.43", | |||
| "serverless-dynamodb": "0.2.45", | |||
There was a problem hiding this comment.
I know this is unrelated to the change, but does this need to be a dependency vs devDependency?
hamiltonrossbjss
approved these changes
Dec 5, 2023
me-matt
approved these changes
Dec 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket title
Adding SonarQube Job to Activities
Fixed Snyk vuln:
serverless-dynamodb": "0.2.43" => serverless-dynamodb": "0.2.45"CB2-10084
Checklist