test

.github/workflows/pr-plan.yml

@@ -1,28 +1,53 @@
 name: PR-checks
 
 on:
- push:
-   branches: ['develop','feature/CB2-10780']
- pull_request:
-   branches: ['develop','feature/CB2-10780']
+  push:
+    branches: ['develop', 'feature/CB2-10780']
+  pull_request:
+    branches: ['develop', 'feature/CB2-10780']
 
 jobs:
+  build-test:
+    runs-on: ubuntu-latest
+
+    strategy:
+      matrix:
+        node-version: [18.x]
+        # See supported Node.js release schedule at https://nodejs.org/en/about/releases/
+
+    steps:
+      - uses: actions/checkout@v3
+      - name: Setup Node.js ${{ matrix.node-version }}
+        uses: actions/setup-node@v3
+        with:
+          node-version: ${{ matrix.node-version }}
+          cache: 'npm'
+      - name: Install dependencies
+        run: npm ci
+      - name: Setup local dynamo
+        run: npm run tools-setup
+      - name: Build and test
+        run: npm run prepush
+        env:
+          AWS_ACCESS_KEY_ID: foo
+          AWS_SECRET_ACCESS_KEY: bar
+      - name: Run linter
+        run: npm run lint
+
   scanner:
     permissions:
       id-token: write
-      contents: write
-      pull-requests: write
     runs-on: X64
     steps:
-      - uses: actions/checkout@v3
+      - uses: actions/checkout@v4
       - uses: actions/setup-node@v4
         with:
           node-version-file: '.nvmrc'
       - uses: aws-actions/configure-aws-credentials@v4
         with:
           role-to-assume: ${{ secrets.CVS_MGMT_AWS_ROLE }}
           aws-region: ${{ secrets.DVSA_AWS_REGION }}
-          role-session-name: 'cvs-svc-technical-records-v3'
+          role-session-name: 'cvs-app-vtm'
       - uses: aws-actions/aws-secretsmanager-get-secrets@v1
         with:
           secret-ids: sonarqube-gha
@@ -31,10 +56,10 @@ jobs:
         run: npm ci
       - name: Run SonarQube scanner
         run: |
-         npm run test && \
-         npm run sonar-scanner -- \
-         -Dsonar.host.url=${{ env.SONARQUBE_GHA_URL }} \
-         -Dsonar.token=${{ env.SONARQUBE_GHA_TOKEN }} \
-         -Dsonar.login=${{ env.SONARQUBE_GHA_TOKEN }} \
-         -Dsonar.projectName=${{ github.repository }} \
-         -Dsonar.projectVersion=1.0.${{ github.run_id }}
+          npm run test && \
+          npm run sonar-scanner -- \
+          -Dsonar.host.url=${{ env.SONARQUBE_GHA_URL }} \
+          -Dsonar.token=${{ env.SONARQUBE_GHA_TOKEN }} \
+          -Dsonar.login=${{ env.SONARQUBE_GHA_TOKEN }} \
+          -Dsonar.projectName=${{ github.repository }} \
+          -Dsonar.projectVersion=1.0.${{ github.run_id }}