CB2-9558: updated no data available, km and mi translations #94
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
m-coslett
reviewed
Oct 31, 2023
src/main/java/uk/gov/dvsa/view/cvs/CvsOdometerReadingFormatter.java
Outdated
Show resolved
Hide resolved
Daniel-Searle
approved these changes
Nov 1, 2023
m-coslett
approved these changes
Nov 2, 2023
cb-cs
added a commit
that referenced
this pull request
Dec 15, 2023
* feat(cb2-9558): updated no data available, km and mi translations * feat(cb2-9558): corrected typo on statics * feat(cb2-9558): updated translation as per feedback
4 tasks
cb-cs
added a commit
that referenced
this pull request
Jan 22, 2024
* feat(vta-1618): duplicated appropriate templates ready for welsh conversion (#87) feat(vta-1618): added failWelsh template feat(vta-1618): added passNoSeatbeltFieldsWelsh template feat(vta-1618): added passWelsh template feat(vta-1618): added VTG30Welsh template * VTA-1574: Generate Welsh Certificate HGV Pass (#88) * feat(vta-1574): added models and updated logic to use vtg5 bilingual * feat(vta-1574): updated naming convention so it makes more sense * feat(vta-1574): added html verification test for vtg5 * feat(vta-1574): added tests for VTG5W * feat(vta-1574): added tests for hgv pass bilingual * feat(vta-1574): updated unit tests * feat(vta-1574): refactored naming convention for statics * feat(vta-1574): added welsh crest logo to passNoSeatbelts hbs * feat(vta-1574): refactored unit tests, added welsh mileage translation * feat(vta-1574): applied welsh miles logic to odometer history * feat(vta-1574): refactored static * VTA-1575: Generate Welsh certificate Trailer - Pass (#90) * feat(vta-1575): welsh certificate for trailer pass * feat(vta-1575): corrected data model on welsh trailer cert * feat(vta-1575): identification number not registration number * feat(vta-1575): regid or heading welsh * feat(vta-1575): corrected regid or heading in bilingual model * VTA-1576: Generate Welsh Certificate PSV Pass (#92) * feat(vta-1576): added new models, updated enums and configs * feat(vta-1576): corrected typo * feat(vta-1576): added new tests * feat(vta-1576): corrected formatting * feat(cb2-9560): rebased against develop and removed loggers * feat(cb2-9560): added logger for debug * feat(cb2-9560): removed loggers used for debug * CB2-9558: updated no data available, km and mi translations (#94) * feat(cb2-9558): updated no data available, km and mi translations * feat(cb2-9558): corrected typo on statics * feat(cb2-9558): updated translation as per feedback --------- Co-authored-by: Melanie Coslett <50204104+m-coslett@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CB2-9558/9559: Update Translations
This PR includes the changes for both CB2-9558 (translate wording of mi/miles and km/kilometres to Welsh word equivalent) and CB2-9559 (translate No data found to Welsh equivalent).
Related issue: CB2-9558
Before submitting (or marking as "ready for review")