Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CB2-10316: Generate Welsh Certificate #97

Merged
merged 8 commits into from
Jan 22, 2024
Merged

CB2-10316: Generate Welsh Certificate #97

merged 8 commits into from
Jan 22, 2024

Conversation

cb-cs
Copy link
Contributor

@cb-cs cb-cs commented Jan 12, 2024

Generate Welsh Certificate

This PR includes all of the changes required on the document generation service to allow Annual Test (Pass/Pass with Minors/Advisories) to be generated for HGV, PSV, TRL's.

Tickets/pieces of work that have been merged into this holding branch are as follows:

Related issue: CB2-10316

Before submitting (or marking as "ready for review")

  • Does the pull request title follow the conventional commit specification?
  • Have you performed a self-review of the code
  • Have you have added tests that prove the fix or feature is effective and working
  • Did you make sure to update any documentation relating to this change?

cb-cs and others added 8 commits December 15, 2023 13:44
…ersion (#87)

feat(vta-1618): added failWelsh template

feat(vta-1618): added passNoSeatbeltFieldsWelsh template

feat(vta-1618): added passWelsh template

feat(vta-1618): added VTG30Welsh template
* feat(vta-1574): added models and updated logic to use vtg5 bilingual

* feat(vta-1574): updated naming convention so it makes more sense

* feat(vta-1574): added html verification test for vtg5

* feat(vta-1574): added tests for VTG5W

* feat(vta-1574): added tests for hgv pass bilingual

* feat(vta-1574): updated unit tests

* feat(vta-1574): refactored naming convention for statics

* feat(vta-1574): added welsh crest logo to passNoSeatbelts hbs

* feat(vta-1574): refactored unit tests, added welsh mileage translation

* feat(vta-1574): applied welsh miles logic to odometer history

* feat(vta-1574): refactored static
* feat(vta-1575): welsh certificate for trailer pass

* feat(vta-1575): corrected data model on welsh trailer cert

* feat(vta-1575): identification number not registration number

* feat(vta-1575): regid or heading welsh

* feat(vta-1575): corrected regid or heading in bilingual model
* feat(vta-1576): added new models, updated enums and configs

* feat(vta-1576): corrected typo

* feat(vta-1576): added new tests

* feat(vta-1576): corrected formatting
* feat(cb2-9558): updated no data available, km and mi translations

* feat(cb2-9558): corrected typo on statics

* feat(cb2-9558): updated translation as per feedback
@cb-cs cb-cs marked this pull request as ready for review January 12, 2024 15:19
@m-coslett m-coslett self-requested a review January 19, 2024 15:48
@cb-cs cb-cs changed the title CB2-10316: Merge VTAWELSH into develop CB2-10316: Generate Welsh Certificate Jan 22, 2024
@cb-cs cb-cs merged commit 3ed7997 into develop Jan 22, 2024
6 checks passed
@cb-cs cb-cs deleted the feature/VTAWELSH-1 branch January 22, 2024 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants